Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Refactor] use mmengine.basemodule instead of nn.module #1491

Merged
merged 11 commits into from
Jan 18, 2023
Merged

[Refactor] use mmengine.basemodule instead of nn.module #1491

merged 11 commits into from
Jan 18, 2023

Conversation

Z-Fran
Copy link
Collaborator

@Z-Fran Z-Fran commented Dec 1, 2022

Thanks for your contribution and we appreciate it a lot. The following instructions would make your pull request more healthy and more easily get feedback. If you do not understand some items, don't worry, just make the pull request and seek help from maintainers.

Motivation

[Refactor] use mmengine.basemodule instead of nn.module

Modification

Use mmengine.basemodule instead of nn.module

  • 1. basicvsr and basicvsr++
  • 2. aot-gan
  • 3. cain
  • 4. deepfillv1_
  • 5. deepfillv2
  • 6. dim
  • 7. edsr
  • 8. edvr
  • 9. gl
  • 10. iconvsr
  • 11. indexnet
  • 12. liif-
  • 13. pconv
  • 14. rdn
  • 15. realbasicvsr
  • 16. realesrnet_
  • 17. realesrgan
  • 18. srcnn
  • 19. msrresnet_
  • 20. srgan
  • 21. tdan

Who can help? @ them here!

BC-breaking (Optional)

Does the modification introduce changes that break the backward-compatibility of the downstream repositories?
If so, please describe how it breaks the compatibility and how the downstream projects should modify their code to keep compatibility with this PR.

Use cases (Optional)

If this PR introduces a new feature, it is better to list some use cases here, and update the documentation.

Checklist

Before PR:

  • I have read and followed the workflow indicated in the CONTRIBUTING.md to create this PR.
  • Pre-commit or linting tools indicated in CONTRIBUTING.md are used to fix the potential lint issues.
  • Bug fixes are covered by unit tests, the case that causes the bug should be added in the unit tests.
  • New functionalities are covered by complete unit tests. If not, please add more unit test to ensure the correctness.
  • The documentation has been modified accordingly, including docstring or example tutorials.

After PR:

  • If the modification has potential influence on downstream or other related projects, this PR should be tested with some of those projects.
  • CLA has been signed and all committers have signed the CLA in this PR.

@Z-Fran Z-Fran added the kind/enhancement refactoring, improving CI, template, etc. label Dec 1, 2022
@Z-Fran Z-Fran added this to the Backlog milestone Dec 1, 2022
@Z-Fran Z-Fran self-assigned this Dec 1, 2022
@Z-Fran Z-Fran linked an issue Dec 1, 2022 that may be closed by this pull request
[Refactoring] use mmengine.basemodule instead of nn.module #1411
Closed
21 tasks
@codecov
Copy link

codecov bot commented Dec 1, 2022 •
edited
Loading

Codecov Report

Base: 87.93% // Head: 88.00% // Increases project coverage by +0.07% 🎉

Coverage data is based on head (2377f1f) compared to base (936c346).
Patch coverage: 89.61% of modified lines in pull request are covered.

Additional details and impacted files 
@@             Coverage Diff             @@
##           dev-1.x    #1491      +/-   ##
===========================================
+ Coverage    87.93%   88.00%   +0.07%     
===========================================
  Files          399      399              
  Lines        26059    26029      -30     
  Branches      4051     4039      -12     
===========================================
- Hits         22914    22906       -8     
+ Misses        2240     2221      -19     
+ Partials       905      902       -3
Flag Coverage Δ
unittests 88.00% <89.61%> (+0.07%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...medit/models/editors/aotgan/aot_encoder_decoder.py 100.00% <ø> (ø)
...ls/editors/deepfillv2/two_stage_encoder_decoder.py 75.75% <33.33%> (+7.33%) ⬆️
mmedit/models/base_archs/smpatch_disc.py 93.75% <60.00%> (+9.96%) ⬆️
mmedit/models/editors/aotgan/aot_decoder.py 100.00% <100.00%> (ø)
mmedit/models/editors/aotgan/aot_encoder.py 100.00% <100.00%> (ø)
mmedit/models/editors/aotgan/aot_neck.py 100.00% <100.00%> (ø)
mmedit/models/editors/basicvsr/basicvsr_net.py 95.31% <100.00%> (ø)
mmedit/models/editors/cain/cain_net.py 98.97% <100.00%> (ø)
.../models/editors/deepfillv1/contextual_attention.py 95.28% <100.00%> (+0.04%) ⬆️
...ls/editors/deepfillv1/contextual_attention_neck.py 100.00% <100.00%> (ø)
... and 16 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@Z-Fran Z-Fran requested review from plyfager and removed request for zengyh1900 December 19, 2022 04:37
plyfager
plyfager previously approved these changes Dec 20, 2022
View reviewed changes
@Z-Fran Z-Fran merged commit 4dcb13f into dev-1.x Jan 18, 2023
@Z-Fran Z-Fran deleted the fix-basemodule branch January 18, 2023 10:42
@Z-Fran Z-Fran mentioned this pull request Mar 2, 2023
Merged
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LeoXing1996 LeoXing1996 LeoXing1996 approved these changes

@plyfager plyfager plyfager left review comments

Assignees

@Z-Fran Z-Fran

Labels
kind/enhancement refactoring, improving CI, template, etc.
Projects
None yet
Milestone
Backlog
Development

Successfully merging this pull request may close these issues.

[Refactoring] use mmengine.basemodule instead of nn.module
3 participants
@Z-Fran @plyfager @LeoXing1996